[wp-trac] [WordPress Trac] #5130: Linking to multiple posts on your site breaks pingback due to comment flooding

WordPress Trac noreply at wordpress.org
Mon Sep 12 03:35:40 UTC 2016


#5130: Linking to multiple posts on your site breaks pingback due to comment
flooding
-------------------------------------------------+-------------------------
 Reporter:  Denis-de-Bernardy                    |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Pings/Trackbacks                     |  Release
 Severity:  normal                               |     Version:  2.3
 Keywords:  has-patch needs-refresh needs-unit-  |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-patch => has-patch needs-refresh needs-unit-tests


Comment:

 [attachment:5130.diff] doesn't really solve the problem, and it doesn't
 make it easy for plugins to solve the problem. (At least, not without
 extra queries on the part of the plugins, which is not ideal for anti-
 flood code.)

 I'm inclined to agree with @nacin's suggestion in #25141 - allow up to 4
 pingbacks quickly before dying.

 This could be implemented by altering the query in
 `check_comment_flood_db()` - add `comment_type` to the `WHERE` condition,
 and when the `comment_type` is a pingback, change the `LIMIT` to `LIMIT 1
 OFFSET 4`, so we're grabbing the time of the 5th most recent pingback. The
 `comment_flood_filter` filter will then act on the older pingback, meaning
 4 pingbacks can be done in 15 seconds before `comment_flood_filter`
 returns `true`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/5130#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list