[wp-trac] [WordPress Trac] #38003: Add oEmbed support for User, List and Like Twitter timelines

WordPress Trac noreply at wordpress.org
Fri Sep 9 16:07:07 UTC 2016


#38003: Add oEmbed support for User, List and Like Twitter timelines
----------------------------------------------------+------------------
 Reporter:  earnjam                                 |       Owner:
     Type:  enhancement                             |      Status:  new
 Priority:  normal                                  |   Milestone:  4.7
Component:  Embeds                                  |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-unit-tests has-patch 2nd-opinion  |     Focuses:
----------------------------------------------------+------------------
Changes (by earnjam):

 * keywords:  needs-patch needs-unit-tests => needs-unit-tests has-patch
     2nd-opinion


Comment:

 [https://core.trac.wordpress.org/attachment/ticket/38003/38003.diff
 38003.diff] adds the other 3 Twitter timeline URLs as trusted providers.

 My regex isn't the best, so someone should look it over and see if there
 is a better way to handle it.

 In that patch I also slightly modified the existing Twitter providers
 because they had a `.` matching any character in the username space, but
 Twitter usernames can only contain alphanumeric characters and
 underscores, so `[\w]` seems like a more specific match. If we'd rather
 keep the wildcard match, then I can make a new patch.

 The `[\w]` change also throws off the nice whitespace alignment on the
 array, but I didn't want to muddy up the commit with whitespace changes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38003#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list