[wp-trac] [WordPress Trac] #34343: Customizer: Make panel headers sticky?

WordPress Trac noreply at wordpress.org
Fri Sep 9 14:12:26 UTC 2016


#34343: Customizer: Make panel headers sticky?
-----------------------------------+------------------------------
 Reporter:  pavelevap              |       Owner:  delawski
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Customize              |     Version:  4.3
 Severity:  normal                 |  Resolution:
 Keywords:  ux-feedback has-patch  |     Focuses:  ui, javascript
-----------------------------------+------------------------------
Changes (by delawski):

 * keywords:  needs-patch ux-feedback => ux-feedback has-patch


Comment:

 I have moved the code responsible for 'sticking' the header out of
 panel/section class, and optimized the way sticky functionality is
 provided:
 * only a single expanded panel/section listens to the scroll event at a
 time;
 * it stops listening right after it is collapsed;
 * most calculations are moved out of the scroll event handler to prevent
 potential lags;
 * moreover, scroll event listener is throttled to further improve
 performance.

 Because of the fact that this new feature is dependant on panel/section
 structure, I'd suggest merging it after #34391 (of course only if #34391
 is going to be pulled into the master).

 [https://core.trac.wordpress.org/attachment/ticket/34343/34343_1.diff|
 I've attached a diff file].

 Also, a PR on GitHub is available:

 https://github.com/xwp/wordpress-develop/pull/155

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34343#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list