[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

WordPress Trac noreply at wordpress.org
Fri Sep 9 00:20:47 UTC 2016


#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:  pento
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.7
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by pento):

 Replying to [comment:232 jorbin]:
 > The above patch fixes this issue, though the more I think about it, the
 more I wonder if WP_Hook should even be in a separate file. Is there ever
 a time you would want one and not the other?

 [attachment:17817.26.diff] will break things in weird ways - if something
 loads `plugin.php` without loading `class-wp-hook.php`, it still won't be
 able to use `add_filter()`, etc. And once `plugin.php` is loaded, it can't
 be relied on to process `$wp_filter` as it does at the top of the file.

 Discussion of the correct fix for that can continue in #37707.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:234>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list