[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

[WordPress Trac]

#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:  pento
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.7
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by jorbin):

 Replying to [comment:229 danielbachhuber]:
 > Replying to [comment:224 danielbachhuber]:
 > > FYI - Because WP-CLI directly modifies the `$wp_filter` global, this
 `WP_Hook` thing breaks the implementation we adopted in #34936.
 >
 > As it turns out, WP-CLI broke because of poor coding on my part. My bad.
 See https://github.com/wp-cli/wp-cli/pull/3384 for the fix.
 >
 > However, I discovered this breaks the intent of #37707 because it
 depends on `WPINC`, which is only available after `wp-settings.php` has
 begun loading.

 The above patch fixes this issue, though the more I think about it, the
 more I wonder if WP_Hook should even be in a separate file. Is there ever
 a time you would want one and not the other?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:232>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform