[wp-trac] [WordPress Trac] #25293: Switch_to_blog not switching the siteid
WordPress Trac
noreply at wordpress.org
Thu Sep 8 18:12:00 UTC 2016
#25293: Switch_to_blog not switching the siteid
------------------------------------------------+--------------------------
Reporter: Rahe | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future
Component: Networks and Sites | Release
Severity: minor | Version: 3.0
Keywords: has-patch dev-feedback 2nd-opinion | Resolution:
| Focuses: multisite
------------------------------------------------+--------------------------
Comment (by flixos90):
Replying to [comment:17 swissspidy]:
> Looking at this ticket, #37958 and #26511, `WP_State` is not a good name
for this site-related class. I'd rather see `WP_Site_State` and
`WP_Locale_State` (currently `WP_Locale_Switcher`) to implement a
`WP_State` interface or an abstract class of such name.
+1, the name should be more specific. Anyone has an idea better than
`WP_Site_State`? I feel that is not accurate enough since it also
indirectly handles the network state (by switching the network
automatically when the site is switched). Regarding an interface, I'm not
sure how this class would have anything in common with `WP_Locale_State`
other than it switches something - might be sufficient for an interface
later, or can you come up with something in particular?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25293#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list