[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

[WordPress Trac]

#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
----------------------------------------------------+---------------------
 Reporter:  kernfel                                 |       Owner:  pento
     Type:  defect (bug)                            |      Status:  closed
 Priority:  normal                                  |   Milestone:  4.7
Component:  Plugins                                 |     Version:  2.2
 Severity:  normal                                  |  Resolution:  fixed
 Keywords:  has-patch needs-testing has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by jacobsantos):

 Oh. Oh dear god. Oh you poor poor people. I am so, so very sorry.

 I guess it will be okay. It should be okay. As long as everything works.
 Looking at the code that was committed...

 I'm sorry. The design decisions that were made years and years ago were
 mostly compromises for PHP4. Things had to work on PHP4 you see, PHP4 had
 priority.

 '''Also, the decision was that we didn't care about plugins affected by
 this bug,''' because at the time it was an edge case. I feel that it still
 is by the way. Looks like I'm going to maintain a separate build of
 WordPress that reverts this mess of a commit.

 '''I don't care.''' You will either regret this commit and revert it or it
 won't matter and my fears will be unfounded. Either way, I think it would
 be a good time for a fork. Or not. It should be fine. I mean, it isn't
 like this patch resembles a patch that was submitted years ago back when
 we had a similar problem and rejected that shit faster than the fastest
 thing you can think that can go fast.

 It is funny to me. How history repeats itself. I hope evil didn't prevail
 this time. Who knows? I forget why a similar solution was rejected so long
 ago. Performance reasons? Must have been performance reasons and PHP4.
 WordPress sucked back when PHP4 had to be supported. Imagine being stuck
 supporting a older version of PHP. What a nightmare.

 I still think it is funny that this whole thing could be solved with one
 line and fuck it, let's just add class! I mean, you can't really solve
 this problem in a good way. Well, you can, you can do what you did in the
 commit.

 You know. I'm sure it will be fine. It'll be fine. PHP5 and PHP7 are way
 faster than they were back in 2007. Servers are way faster than they were
 in 2007.

 Well. Good luck. I'll make sure the door doesn't hit my ass on the way out
 again.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:216>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform