[wp-trac] [WordPress Trac] #35206: Allow theme authors to control white space between menu items

WordPress Trac noreply at wordpress.org
Thu Sep 8 05:04:38 UTC 2016


#35206: Allow theme authors to control white space between menu items
----------------------------------+----------------------------
 Reporter:  peterwilsoncc         |       Owner:  peterwilsoncc
     Type:  enhancement           |      Status:  reopened
 Priority:  normal                |   Milestone:  4.7
Component:  Menus                 |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-docs has-patch  |     Focuses:  template
----------------------------------+----------------------------
Changes (by peterwilsoncc):

 * keywords:  needs-docs needs-patch => needs-docs has-patch


Comment:

 In [attachment:35206.7.diff], there's a fix to avoid having notices when
 `Walker_Nav_Menu` is extended but methods are called with different
 arguments.

 @dgwyer you're correct, I decided to keep the logic and assignments
 identical throughout. The intent is to lower the risk of failure if a the
 class is extended and logic is copy-pasted.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35206#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list