[wp-trac] [WordPress Trac] #37966: Comment children missing on paged comment views

[WordPress Trac]

#37966: Comment children missing on paged comment views
--------------------------+-----------------------------
 Reporter:  dd32          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Comments      |    Version:  4.6
 Severity:  major         |   Keywords:  needs-patch
  Focuses:                |
--------------------------+-----------------------------
 Comment children comments do not appear to be being displayed when
 comments are paged.

 The scenario is hard to explain without a visual, but here's some simple
 reproduction steps:
 - Create a post with 2 top-level comments
 - Create two replies for the comments. You now have a post with 4
 comments.
 - Set comment threading to ` Break comments into pages with 1 top level
 comments per page and the  last page displayed by default`
 - View the comment pages for the post, Only the top-level comments are
 visible on all but the ''first'' page.
 - Add extra comments, top-level comments remain visible and cause
 pagination, child comments continue to not display on all but the first
 page.

 This is not specific to `1` comments per page, it occurs with larger data
 sets as well.

 Attached is an attempt at a unit test which shows something that succeeds
 under 4.5, but fails under 4.6 - I'm not sure if that's testing the actual
 code thats failing, but it's where I've gotten to after digging through
 `comments_template()` and `WP_Comment_Query`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37966>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform