[wp-trac] [WordPress Trac] #37827: Some classes still need to be moved into their own file

WordPress Trac noreply at wordpress.org
Tue Sep 6 18:21:03 UTC 2016


#37827: Some classes still need to be moved into their own file
----------------------------+---------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:  4.7
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:  fixed
 Keywords:                  |     Focuses:
----------------------------+---------------------

Comment (by ocean90):

 Replying to [comment:11 wonderboymusic]:
 > In [changeset:"38379"]:
 > {{{
 > #!CommitTicketReference repository="" revision="38379"
 > Upgrade/Install: `wp-admin/includes/class-wp-upgrader-skins.php` is
 unused, remove it. All of the same includes are loaded in `class-wp-
 upgrader.php`.
 >
 > See #37827.
 > }}}

 This is going to break plugins - if there won't be an autoloader in 4.7 -
 which do`if ( ! class_exists( 'WP_Upgrader_Skin' ) ) { require_once
 ABSPATH . 'wp-admin/includes/class-wp-upgrader-skins.php'; }`.

 See also [comment:ticket:36335:185]. I think there should be a deprecation
 notice first.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37827#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list