[wp-trac] [WordPress Trac] #37280: Remove boldness from update notices
WordPress Trac
noreply at wordpress.org
Mon Sep 5 02:57:45 UTC 2016
#37280: Remove boldness from update notices
--------------------------------------+-----------------------------
Reporter: ocean90 | Owner: Presskopp
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future Release
Component: General | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: ui
--------------------------------------+-----------------------------
Comment (by dd32):
Replying to [comment:5 Presskopp]:
> Ok, if I'm not mistaking, that makes it a patch. But wait! Is there any
good in this:
>
> `printf(__('Comment by %s moved to the trash.'), '<strong></strong>');`
> `printf(__('Comment by %s marked as spam.'), '<strong></strong>');`
If you look at how it's actually used in the UI, the JS fills the
`<strong>` tags in with the commenter's name.
Javascript doesn't understand `%s` as a placeholder, so HTML tags are used
instead. If we want to remove the bolding of the username here we'd need
to replace it with something such as `<span></span>` and update whatever
JS uses it to search for the `span` tag rather than `strong`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37280#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list