[wp-trac] [WordPress Trac] #37890: `WP_Customize_Manager::prepare_setting_validity_for_js()` assumes `$error_data` is array

WordPress Trac noreply at wordpress.org
Fri Sep 2 06:18:13 UTC 2016


#37890: `WP_Customize_Manager::prepare_setting_validity_for_js()` assumes
`$error_data` is array
--------------------------+--------------------------
 Reporter:  dlh           |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:  4.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------

Comment (by westonruter):

 @dlh Good question. I think the idea on not checking for a modified
 `notification.message` is that generally the message would just be a
 human-readable version of the `notification.code`. But since this was
 unexpected for you, it's probably not something that should in fact be
 assumed. I've updated the patch to also check for a difference in
 `message`: [attachment:37890.3.diff]. If that works for you, I'll commit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37890#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list