[wp-trac] [WordPress Trac] #34981: Usage of `image_size_names_choose` breaks JS attachment model attributes

WordPress Trac noreply at wordpress.org
Fri Sep 2 03:10:05 UTC 2016


#34981: Usage of `image_size_names_choose` breaks JS attachment model attributes
------------------------------------+--------------------
 Reporter:  dnaber-de               |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  4.7
Component:  Media                   |     Version:  4.3.1
 Severity:  normal                  |  Resolution:
 Keywords:  needs-docs needs-patch  |     Focuses:
------------------------------------+--------------------
Changes (by jorbin):

 * keywords:  has-patch needs-docs => needs-docs needs-patch


Comment:

 Thought for a second that maybe the `image_size_names_choose` filter could
 just be removed, but that would reintroduce #22598.

 I think context is going to be the key, but I agree with @dnaber-de that
 it shouldn't be tied to the name of the function, but to the actual
 context.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34981#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list