[wp-trac] [WordPress Trac] #37634: Wrong usage of $gmt parameter in date_i18n() in options-general.php

[WordPress Trac]

#37634: Wrong usage of $gmt parameter in date_i18n() in options-general.php
--------------------------------------+---------------------
 Reporter:  swissspidy                |       Owner:  jorbin
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  4.7
Component:  Administration            |     Version:  3.1
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+---------------------
Changes (by jorbin):

 * owner:   => jorbin
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38502"]:
 {{{
 #!CommitTicketReference repository="" revision="38502"
 Administration: Use a bool when when a bool is called for

 The third parameter of `date_i18n` is a bool.  Currently, it's a weak
 check, otherwise the call showing the universal time on the "General
 Settings" screen would be messed up. Use an actual bool so we call our own
 functions correctly.

 Fixes #37634.
 Props fronaldaraujo.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37634#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform