[wp-trac] [WordPress Trac] #38592: Customizer preview fails to persist state query params through history.pushState() calls

WordPress Trac noreply at wordpress.org
Mon Oct 31 16:41:08 UTC 2016


#38592: Customizer preview fails to persist state query params through
history.pushState() calls
--------------------------+--------------------------
 Reporter:  westonruter   |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * owner:   => westonruter
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39060"]:
 {{{
 #!CommitTicketReference repository="" revision="39060"
 Customize: Ensure state query params persist in preview through calls to
 `history.pushState()` & `history.replaceState()`.

 Allow history to be manipulated before DOM ready by sourcing state params
 from the current URL instead of from the `wp.customize.settings` object,
 since they will be the same anyway. This fixes a JS error since
 `wp.customize.settings` is not defined before DOM ready.

 Amends [38810].
 See #30937.
 Fixes #38592.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38592#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list