[wp-trac] [WordPress Trac] #37893: Implementation of is_registered_sidebar() doesn't match its documented signature

[WordPress Trac]

#37893: Implementation of is_registered_sidebar() doesn't match its documented
signature
--------------------------+-----------------------
 Reporter:  mdgl          |       Owner:  welcher
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  Widgets       |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  docs
--------------------------+-----------------------
Changes (by welcher):

 * keywords:  needs-patch 2nd-opinion => needs-patch


Comment:

 @mdgl I applied both patches and got the same failure on each.

 As to the second opinion, I think that introducing changes that cause
 errors in order to match the documentation is not the best approach. In
 this case, I would say that the fix is to update the inline documentation
 and be explicit as to the discrepancies.

 To your point, we will need to have a higher-level look at to the best way
 of standardizing these functions.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37893#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform