[wp-trac] [WordPress Trac] #29783: User Admin Language
WordPress Trac
noreply at wordpress.org
Sun Oct 30 21:37:29 UTC 2016
#29783: User Admin Language
-----------------------------+-----------------------------
Reporter: faevilangel | Owner: ocean90
Type: feature request | Status: closed
Priority: normal | Milestone: 4.7
Component: I18N | Version: 4.0
Severity: normal | Resolution: fixed
Keywords: needs-dev-note | Focuses: administration
-----------------------------+-----------------------------
Comment (by johnjamesjacoby):
A few things I see that need fixing:
* When editing a user profile, the label is for `site_language` but the
select name is `locale`. I recommend keeping `locale` -- I think
`site_language` is copy-pasta from the site setting.
* The profile code uses `get_user_option( 'locale', $profileuser->ID )`
instead of the `get_user_locale()` function. Why can a user set a per-site
language, but `wp_insert_user()` sets `locale` using `update_user_meta()`?
* Also, `_get_additional_user_keys()` includes `locale` as a global piece
of meta, not as a per-site option.
I'll include patches with recommended fixes.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29783#comment:70>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list