[wp-trac] [WordPress Trac] #38225: Improve documentation for is_single()
WordPress Trac
noreply at wordpress.org
Fri Oct 28 20:47:19 UTC 2016
#38225: Improve documentation for is_single()
----------------------------------------+-------------------
Reporter: danburzo | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: General | Version:
Severity: normal | Resolution:
Keywords: needs-patch good-first-bug | Focuses: docs
----------------------------------------+-------------------
Comment (by ryankienstra):
'''Request For Code Review'''
Hi @ocean90,
Could you please review this
[https://core.trac.wordpress.org/attachment/ticket/38225/38225.diff
patch], which changes the documentation from:
```* Works for any post type, except attachments and pages ```
to:
```* Works for any post type, except pages.```
As you showed in your [https://core.trac.wordpress.org/ticket/38225#trac-
change-1-1475579200365162 comment], `is_single()` does work for attachment
post types. You [https://core.trac.wordpress.org/browser/trunk/src/wp-
includes/class-wp-query.php?rev=38586&marks=808-810#L806 pointed to] how
[https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
query.php?rev=38586&marks=808-810#L809 is_single()] will be true for
attachments.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38225#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list