[wp-trac] [WordPress Trac] #32315: $wpdb->insert fails without error msg

[WordPress Trac]

#32315: $wpdb->insert fails without error msg
------------------------------------------+------------------------------
 Reporter:  dlt101                        |       Owner:
     Type:  defect (bug)                  |      Status:  reopened
 Priority:  normal                        |   Milestone:  Awaiting Review
Component:  Database                      |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+------------------------------

Comment (by mnelson4):

 > should it also truncate values and carry on with the insert if
 necessary, or fail and return an error?

 I think it should just fail and return an error. Truncating values somehow
 introduced a security problem, which is how this secure-but-unhelpful code
 was introduced in the first place (see my earlier comment where I pointed
 to the security release where this bug was introduced and the exact
 commit). Right @pento ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32315#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform