[wp-trac] [WordPress Trac] #37893: Implementation of is_registered_sidebar() doesn't match its documented signature

[WordPress Trac]

#37893: Implementation of is_registered_sidebar() doesn't match its documented
signature
--------------------------+-----------------------
 Reporter:  mdgl          |       Owner:  welcher
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  Widgets       |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  docs
--------------------------+-----------------------
Changes (by welcher):

 * keywords:  has-patch needs-testing 2nd-opinion => needs-patch


Comment:

 Can we regenerate the patch from the root level of the repo as opposed to
 the `src` folder? This will allow us to add unit tests to the same patch.

 Also, there was a failure when running unit tests after I applied the
 patch:

 {{{
 Tests_Widgets::test_unregister_sidebar_with_numeric_id
 Failed asserting that an array does not have the key 2.

 /srv/www/wordpress-develop/tests/phpunit/tests/widgets.php:237
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37893#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform