[wp-trac] [WordPress Trac] #38499: Customize: newly-added pages should show that they were added to the menu
WordPress Trac
noreply at wordpress.org
Thu Oct 27 22:46:45 UTC 2016
#38499: Customize: newly-added pages should show that they were added to the menu
-------------------------------------------------+-------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch has-screenshots good- | Focuses: ui,
first-bug | javascript
-------------------------------------------------+-------------------------
Comment (by ryankienstra):
'''Request For Review'''
Hi @celloexpressions,
Could you please review the
[https://core.trac.wordpress.org/attachment/ticket/38499/186.diff attached
patch], or the identical [https://github.com/xwp/wordpress-
develop/pull/186 GitHub pull request]?
This passes the [https://github.com/xwp/wordpress-develop/pull/186/files
#diff-49c6fb18cfad3f9946aa8ca15b809b3fL850 available-menu-item template] a
value of `true` for [https://github.com/xwp/wordpress-
develop/compare/trac-38499?expand=1#diff-
027b34627f17d21422fd5065315a6226R589 is_new_item]. The template will then
output the class `item-added`, as you
[https://core.trac.wordpress.org/ticket/38499#trac-
change-2-1477591722273107 suggested].
''Background:
''Adding a new page to a menu in the Customizer uses the template
[https://github.com/xwp/wordpress-develop/pull/186/files#diff-
49c6fb18cfad3f9946aa8ca15b809b3fL850 available-menu-item]. Existing pages
also use this template, so this can't simply output the class for all of
them.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38499#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list