[wp-trac] [WordPress Trac] #38485: Some part of the UI can be in the wrong language (edge cases)

WordPress Trac noreply at wordpress.org
Wed Oct 26 21:02:56 UTC 2016


#38485: Some part of the UI can be in the wrong language (edge cases)
---------------------------------------+-------------------------
 Reporter:  afercia                    |       Owner:  swissspidy
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.7
Component:  I18N                       |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-------------------------

Comment (by yale01):

 Hi @swissspidy, you're right, and I also realized later that the diff
 filename is wrong. Apologies :(

 Your patch is clearly better, but it still re-loads the text domain when
 the `$locale` argument has the same not null value in different calls, and
 it can go worse if in the first call it has a value and the second one is
 null.

 Maybe we could store the `$locale` value in a static var and compare it
 against the fresh argument ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38485#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list