[wp-trac] [WordPress Trac] #38502: TwentySeventeen: unnecessary l10n variables

[WordPress Trac]

#38502: TwentySeventeen: unnecessary l10n variables
---------------------------+--------------------
 Reporter:  enodekciw      |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+--------------------
Description changed by ocean90:

Old description:

> Hey,
>
> Since https://core.trac.wordpress.org/changeset/38909, both
>
> {{{
> if ( 'true' === twentyseventeenScreenReaderText.has_navigation )
> }}}
>
> conditionals in ```/twentyseventeen/assets/js/global.js``` can be changed
> to
>
> {{{
> if ( $menuScrollDown.length )
> }}}
>
> which would also allow ```$twentyseventeen_l10n['has_navigation']``` to
> be completely removed from ```functions.php```

New description:

 Hey,

 Since [38909], both

 {{{
 if ( 'true' === twentyseventeenScreenReaderText.has_navigation )
 }}}

 conditionals in `/twentyseventeen/assets/js/global.js` can be changed to

 {{{
 if ( $menuScrollDown.length )
 }}}

 which would also allow `$twentyseventeen_l10n['has_navigation']` to be
 completely removed from `functions.php`

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38502#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform