[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by celloexpressions):

 Nice work @bradyvercher, thanks!

 @davidakennedy those first two issues are quirks with the way customizer
 notifications work. When a setting is invalid, you can't save your changes
 and the preview won't update. I'm thinking an error notification may not
 be the best approach for the unused-external-video case (we may need to
 remove that check entirely), but it's probably the best option for the
 rest of the validation checks.

 It looks like the remaining issues are:
 - Adding a minimal play/pause `button`, which themes can style, and
 designing a style for that in Twenty Fourteen and Seventeen. Maybe add
 basic SVG-ified dashicons for those, so the frontend can load the icons
 directly instead of loading dashicons? Then themes can adjust the styling
 and colors of the button?
 - Add classes to facilitate theme styling.
 - Consider removing the error validation that prevents having both a local
 and external video set.
 - Consider elaborating on the section-level help text and moving it behind
 a help icon (via the new capability to do that in customizer sections).

 I'm comfortable with an initial commit without those adjustments if the
 issues with loop and selective refresh are resolved in
 [attachment:38172.9.diff], I haven't been able to test thoroughly yet.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform