[wp-trac] [WordPress Trac] #38502: TwentySeventeen: unnecessary l10n variables
WordPress Trac
noreply at wordpress.org
Wed Oct 26 00:31:09 UTC 2016
#38502: TwentySeventeen: unnecessary l10n variables
---------------------------+-----------------------------
Reporter: enodekciw | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version: trunk
Severity: normal | Keywords:
Focuses: |
---------------------------+-----------------------------
Hey,
Since https://core.trac.wordpress.org/changeset/38909, both
{{{
if ( 'true' === twentyseventeenScreenReaderText.has_navigation )
}}}
conditionals in ```/twentyseventeen/assets/js/global.js``` can be changed
to
{{{
if ( $menuScrollDown.length )
}}}
which would also allow ```$twentyseventeen_l10n['has_navigation']``` to be
completely removed from ```functions.php```
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38502>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list