[wp-trac] [WordPress Trac] #38485: Some part of the UI can be in the wrong language (edge cases)

WordPress Trac noreply at wordpress.org
Tue Oct 25 20:28:46 UTC 2016


#38485: Some part of the UI can be in the wrong language (edge cases)
---------------------------------------+-------------------------
 Reporter:  afercia                    |       Owner:  swissspidy
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.7
Component:  I18N                       |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-------------------------

Comment (by ocean90):

 @yale01 Thanks for your patch! Calling `load_textdomain()` a second time
 for the same textdomain doesn't work at the moment, there needs to be a
 call to `unload_textdomain()` first.

 For back-compat I think `wp_timezone_choice()` should get an optional
 `$locale` parameter which falls back to `get_locale()` if it's not set.
 When calling  `wp_timezone_choice()` in the admin we should pass
 `get_user_locale()` to the function.

 Please take also a look at our [https://make.wordpress.org/core/handbook
 /best-practices/coding-standards/php/ coding standards for PHP], there are
 some missing spaces in your patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38485#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list