[wp-trac] [WordPress Trac] #35272: .menu-item-home class not applying to static front pages

[WordPress Trac]

#35272: .menu-item-home class not applying to static front pages
---------------------------------------------+-----------------------
 Reporter:  RachieVee                        |       Owner:  pento
     Type:  defect (bug)                     |      Status:  reopened
 Priority:  normal                           |   Milestone:  4.7
Component:  Menus                            |     Version:  4.4
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-----------------------

Comment (by mdgl):

 Yes!  I suspect the unit tests should also include at least one negative
 case: a menu entry referring to a page that is not marked "on front"
 should **not** contain the `menu-item-home` class.

 I think this is why John Blackbourn got a bit fed up with #32367 as to
 create good coverage here the number of test cases required is actually
 quite large when you include all possible classes, object types and
 hierarchic combinations.  He did say, however that he was "nearly there"
 over a year ago!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35272#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform