[wp-trac] [WordPress Trac] #35272: .menu-item-home class not applying to static front pages

[WordPress Trac]

#35272: .menu-item-home class not applying to static front pages
----------------------------------------+-----------------------
 Reporter:  RachieVee                   |       Owner:  pento
     Type:  defect (bug)                |      Status:  reopened
 Priority:  normal                      |   Milestone:  4.7
Component:  Menus                       |     Version:  4.4
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------

Comment (by mdgl):

 The new patch looks better to me and from my limited testing it appears to
 work correctly.  Are we sure that there are no additional conditions
 required to ensure that the comparison with `front_page_id` remains valid
 in all circumstances?  I would guess so but can't be completely confident.

 In general, I still find the overall logic in function
 `_wp_menu_item_classes_by_context()` very confusing and wouldn't be
 surprised if there were a few more bugs lurking in this area :-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35272#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform