[wp-trac] [WordPress Trac] #38023: Menus screen: simplify the Menu Settings controls
WordPress Trac
noreply at wordpress.org
Tue Oct 25 07:56:05 UTC 2016
#38023: Menus screen: simplify the Menu Settings controls
---------------------------------------+--------------------------------
Reporter: afercia | Owner: rianrietveld
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch | Focuses: ui, accessibility
---------------------------------------+--------------------------------
Comment (by afercia):
Yeah @GaryJ totally agree. It's a general issue in core and it's true also
for jQuery selectors: they shouldn't ever use elements as selectors (or
part of it) because then changing the markup becomes harder. Performance
also could be a concern (at least it was in the past). Also lowering
specificity is a very good point. I'd like to see these points raised up
looking at the big picture, and I'd love to see some work on the
[https://make.wordpress.org/core/2014/12/19/core-css-roadmap/ CSS roadmap]
having a start. There are also other considerations, for example in my
view:
- all the core CSS selectors should use some prefix, e.g. `wp-`
- they should use some sort of naming convention (not necessarily BEM)
- CSS selectors used for JavaScript shouldn't be used for styling
That said, this specific case is a very minor one but it's a good
opportunity to show some best practices so I'm in favor of using some new
classes.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38023#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list