[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------
Changes (by celloexpressions):

 * keywords:  has-patch => has-patch ui-feedback ux-feedback dev-feedback
     has-screenshots
 * focuses:   => ui, accessibility, javascript


Comment:

 [attachment:38172.8.diff] adds additional validation for file format and
 to inform users that their external video won't be used if a local video
 is set. It also adjusts the size limit back to 8MB per Slack conversation
 above and refreshes the patch for changes in Twenty Seventeen's directory
 structure.

 I see potential improvements in the theme API functions, fixing selective
 refresh for the JS-based frontend approach (any ideas here
 @bradyvercher?), fixing local video not looping with the JS approach (also
 something @bradyvercher could help with?) improving the inline help text,
 and potential adjustments in Twenty Seventeen as the outstanding issues
 here, most of which could be addressed during beta if needed.

 '''Please test and identify any blockers for an initial commit in the next
 ~36 hours'''. The JS-based initialization on the frontend needs the most
 work and is still largely in proof-of-concept stage. If we can't get the
 JS approach for the front end polished up, we may need to go back to
 something like [attachment:38172.diff] for the output and only support
 self-hosted video for now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform