[wp-trac] [WordPress Trac] #38377: Empty favicons cause extra HTTP requests to customizer when history.replaceState() used

WordPress Trac noreply at wordpress.org
Tue Oct 25 04:46:38 UTC 2016


#38377: Empty favicons cause extra HTTP requests to customizer when
history.replaceState() used
--------------------------+--------------------------
 Reporter:  westonruter   |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38901"]:
 {{{
 #!CommitTicketReference repository="" revision="38901"
 Customize: Prevent absent site icon `link` from outputting an empty string
 as `href` in customizer; use `/favicon.ico` as fallback.

 An empty string causes some browsers to use the current URL as the `href`.
 When using `history.replaceState()` Chrome will re-fetch the favicon with
 each call, meaning that `customize.php` gets hit with wasted requests
 which tax the server.

 Fixes #38377.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38377#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list