[wp-trac] [WordPress Trac] #35272: .menu-item-home class not applying to static front pages

[WordPress Trac]

#35272: .menu-item-home class not applying to static front pages
-----------------------------------------------+-----------------------
 Reporter:  RachieVee                          |       Owner:  pento
     Type:  defect (bug)                       |      Status:  reopened
 Priority:  normal                             |   Milestone:  4.7
Component:  Menus                              |     Version:  4.4
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch commit needs-unit-tests  |     Focuses:
-----------------------------------------------+-----------------------
Changes (by mdgl):

 * keywords:  has-patch commit => has-patch commit needs-unit-tests
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Pardon me if I'm being stupid, but how is this patch supposed to work?
 The value being tested in the `if` statement looks just like a constant
 string to me.  When I apply the patch, I get the class `menu-item-home`
 added on current taxonomy menu items and current but non-home pages as
 well as on the front page.  I think a new patch and some unit tests are
 needed, see #32367.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35272#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform