[wp-trac] [WordPress Trac] #31050: Better PDF Upload Management

[WordPress Trac]

#31050: Better PDF Upload Management
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:
     Type:  feature request                      |  mikeschroder
 Priority:  normal                               |      Status:  assigned
Component:  Media                                |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-unit-tests needs-    |  Resolution:
  testing                                        |     Focuses:  ui
-------------------------------------------------+-------------------------

Comment (by mikeschroder):

 In [attachment:31050.3.diff]:
 * Work around black thumbnail issue.
 * Name full image '.jpg' rather than '.pdf.jpg'
 * Generate more sizes (thumbnail, medium, large, full)
 * Make thumbnail not crop by default.
 * Use medium by default in gallery
 * Use large by default in attachment details.
 * Lower rendering DPI to 128. This reduces all PDF rendered image quality,
 but also reduces the chances of timeouts. We'll have to decide what
 compromise we're comfortable with here.

 Left:
 * Decide what to do with full images, whether to discard, or how to store
 in meta if we're still going to. If we don't store in meta, we'll need to
 change to checking for whether there is an image representation for a non-
 image filetype a different way. I actually don't mind the way this is
 working currently, since it signals "The 'file' isn't an image, so the
 'full' rendered image is here."
 * Figure out why `data.size.url` isn't getting set by the time we hit the
 checks in `media-template.php`.  I've added the extra sizes, and they're
 being sent via JS like with standard images (`data.sizes`), but the
 "default" isn't getting set to medium, which is why it's being hardcoded
 currently. I'm probably missing something obvious here, so would
 appreciate any pointers here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31050#comment:90>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform