[wp-trac] [WordPress Trac] #18375: Post type templates
WordPress Trac
noreply at wordpress.org
Sun Oct 23 12:55:13 UTC 2016
#18375: Post type templates
--------------------------------------+-------------------------
Reporter: johnbillion | Owner: swissspidy
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.7
Component: Posts, Post Types | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: template
--------------------------------------+-------------------------
Comment (by ocean90):
I have no strong opinion on the feature per se, but I can give you some
feedback on [attachment:18375.5.diff]
* Shouldn't `Template Type` be `Template Post Type` to make it clear that
it's for post types?
* Using `theme_page_templates` for all post types could be a back-compat
issue. Maybe `theme_page_templates` should only be used for the post type
`page` and a new one, `theme_post_templates`, for other post types.
* No yoda conditions for <, >, <= or >=.
(https://make.wordpress.org/core/handbook/best-practices/coding-
standards/php/#yoda-conditions)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/18375#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list