[wp-trac] [WordPress Trac] #38389: Twenty Seventeen: Refresh color patterns for changes in style.css

[WordPress Trac]

#38389: Twenty Seventeen: Refresh color patterns for changes in style.css
---------------------------+----------------------------
 Reporter:  melchoyce      |       Owner:  davidakennedy
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+----------------------------
Changes (by celloexpressions):

 * owner:  celloexpressions => davidakennedy
 * status:  assigned => reviewing


Comment:

 [attachment:38389.diff] re-syncs the `color-patterns.php` template with
 all of the changes between October 4th and core merge that were committed
 to `style.css`. Unfortunately, the way git works, it's extremely tedious
 to do this since there are cross-merges across branches and a lot of
 iterations to diffs to fix coding standards, etc. in the history. This is
 pretty close, but I imagine there will be a few more bugs that spring up.

 The dark scheme should probably be entirely remade based on the revised
 color patterns file. If someone can list out how each color should be
 mapped from the originals again that would help, then there are some
 additional color inversions that may be needed on top of it. I didn't
 apply custom colors to the dark playlist styles, and I suppose that if
 someone is using the dark scheme they'd select the dark playlist style
 anyway, so probably don't need to change anything there.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38389#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform