[wp-trac] [WordPress Trac] #38449: Twenty Seventeen: clean up excessive escaping in color-patterns.php
WordPress Trac
noreply at wordpress.org
Sat Oct 22 18:57:05 UTC 2016
#38449: Twenty Seventeen: clean up excessive escaping in color-patterns.php
------------------------------+-------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version: trunk
Severity: normal | Keywords: needs-patch
Focuses: |
------------------------------+-------------------------
For some reason, the `$hue` and `$saturation` variables have `esc_attr`
every single time they appear in the CSS, making the CSS virtually
unreadable. If these variables need to be escaped they should be escaped
once when they're set. `absint` would be more appropriate for both anyway,
as they're positive integers, then a `%` is appended to the saturation
var. This is essentially a CSS file and the PHP pieces need to be as
minimal/efficient as possible for readability.
Patch should wait for #38389 to avoid conflicting patches.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38449>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list