[wp-trac] [WordPress Trac] #24661: remove_accents is not removing combining accents

[WordPress Trac]

#24661: remove_accents is not removing combining accents
----------------------------------+--------------------
 Reporter:  NumidWasNotAvailable  |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  4.7
Component:  Formatting            |     Version:  1.2.1
 Severity:  normal                |  Resolution:
 Keywords:  has-patch             |     Focuses:
----------------------------------+--------------------
Changes (by pento):

 * keywords:  has-patch dev-feedback => has-patch


Comment:

 Initial thoughts on [attachment:24661.5.patch]:

 * Where are `gen_cat_regex_alts.php` and `gen_script_regex_alts.php`?
 Ideally, these should be run as part of the build process, so it's built
 automatically.
 * I'm undecided about `regex_alts.php` being a separate file, it feels
 unnecessary. The regex will only be parsed if it's run, so the performance
 difference on load time will be negligible.
 * The `test_remove_accents_mn_combining_marks()` test only tests Unicode
 5, it should include tests for Unicode 9. Similarly, I'd like to see these
 tests generated automatically.
 * The testing parameter for `_wp_can_use_pcre_ucp()` feels pretty hacky.
 It's less bad due to being an internal function, but still not great.
 What's the performance benefit of using the `static` flag over just
 running the regex every time it's called?
 * I currently have no comment on the change to `remove_accents()`, because
 it's Saturday, and I'm not doing that deep a dive on my weekend. :-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24661#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform