[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers
WordPress Trac
noreply at wordpress.org
Fri Oct 21 03:34:07 UTC 2016
#38172: Enable Video Headers in Custom Headers
----------------------------+--------------------
Reporter: davidakennedy | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 4.7
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
----------------------------+--------------------
Comment (by celloexpressions):
[attachment:38172.diff] (sorry, looks like we didn't start at 0 so that
didn't auto-number) adds validation in the customizer that prevents videos
over 8MB from being used. It also adds initial support to Twenty
Seventeen, although I got a bit lost with the current header logic there
so @laurelfulford should probably work on that next. We need to update the
header image to use an `img` instead of a background image so that we can
use the new template tag that handles both.
That's based on [attachment:38172.3.diff], but could be easily moved over
to [attachment:38172.4.diff] if we decide to go that route. I would prefer
the simpler approach for now, and it could be expanded to do the JS part
and support YouTube in the future if needed. However, WordPress has
supported self-hosted video for over 3 years now. It's time to start
pushing for making that a usable experience instead of having to rely on
3rd-party services. Since this feature is intended for short decorative
videos, it seems like the ideal place to focus on self-hosted video and
try to catalyze broader improvements to that experience.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list