[wp-trac] [WordPress Trac] #38422: Coding Style in TwentySeventeen

[WordPress Trac]

#38422: Coding Style in TwentySeventeen
---------------------------+----------------------------
 Reporter:  aaroncampbell  |       Owner:  davidakennedy
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:  duplicate
 Keywords:  has-patch      |     Focuses:
---------------------------+----------------------------

Comment (by aaroncampbell):

 It looks like it happened in
 [https://github.com/WordPress/twentysixteen/commit/2cf2125dc88b5d67a4cf57c340b9030f7548d506
 this commit] but has no reference to why the change from the classic `if()
 {}` to the unused `test && $var = 'value';`

 Honestly, it's not as easy to read, it's not as standard, and it doesn't
 happen anywhere else in core. To me, that's enough to change it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38422#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform