[wp-trac] [WordPress Trac] #38403: Twenty Seventeen: Comment by post author SVG

[WordPress Trac]

#38403: Twenty Seventeen: Comment by post author SVG
---------------------------+------------------
 Reporter:  samikeijonen   |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------
Changes (by laurelfulford):

 * keywords:  needs-patch => has-patch


Comment:

 I investigated a couple ways to add the `.bypostauthor` SVG icon inline,
 but both seem a bit too much for this one thing. I tried the following:

 * Adding a filter to append it to the author name using
 `get_comment_author`; unfortunately this adds it everywhere, and even when
 restricted to single posts and pages affects comments in widgets. We can
 hide with CSS, but that seems hacky.
 * Creating a Comment Walker or callback (like how Twenty Twelve handles
 adding the string 'post author'). Twenty Seventeen doesn't actually change
 any other markup in the comments, though, so this seems like overkill.

 I discussed with @melchoyce and she suggested altering the design a bit to
 avoid doing anything over the top to add the SVG (mockup attached). The
 patch adds that design, plus updates rtl.css, colors-dark.css, and color-
 patterns.php.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38403#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform