[wp-trac] [WordPress Trac] #38404: Twenty Seventeen: Hidden article tags on home page

[WordPress Trac]

#38404: Twenty Seventeen: Hidden article tags on home page
---------------------------+------------------
 Reporter:  ElectricFeet   |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+------------------

Old description:

> reat theme! Very impressed. Thanks 👍
>
> I'm playing around with it to see its potential and note that when a
> front-page panel is unused, the resulting html has (for example):
>

> {{{
> <article id="panel3" class="panel-placeholder panel twentyseventeen-panel
> twentyseventeen-panel3">
> <span class="twentyseventeen-panel-title">Panel 3 Placeholder</span>
> with
>
> article.panel-placeholder {
>     display: none;
> }
>
> .twentyseventeen-front-page.twentyseventeen-customizer #primary article
> .panel-placeholder {
>     border: 0;
> }
> }}}
>
> in the CSS.
>
> Is this correct in terms of best practice? Could the php take care of not
> outputting this html rather than relying on CSS?

New description:

 reat theme! Very impressed. Thanks

 I'm playing around with it to see its potential and note that when a
 front-page panel is unused, the resulting html has (for example):


 {{{
 <article id="panel3" class="panel-placeholder panel twentyseventeen-panel
 twentyseventeen-panel3">
 <span class="twentyseventeen-panel-title">Panel 3 Placeholder</span>
 with

 article.panel-placeholder {
     display: none;
 }

 .twentyseventeen-front-page.twentyseventeen-customizer #primary article
 .panel-placeholder {
     border: 0;
 }
 }}}

 in the CSS.

 Is this correct in terms of best practice? Could the php take care of not
 outputting this html rather than relying on CSS?

--

Comment (by karmatosed):

 Ticket moved over from GitHub as part of merge. There is more context
 here: https://github.com/WordPress/twentyseventeen/issues/339

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38404#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform