[wp-trac] [WordPress Trac] #31050: Better PDF Upload Management

[WordPress Trac]

#31050: Better PDF Upload Management
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:
     Type:  feature request                      |  mikeschroder
 Priority:  normal                               |      Status:  assigned
Component:  Media                                |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-unit-tests needs-    |  Resolution:
  testing                                        |     Focuses:  ui
-------------------------------------------------+-------------------------

Comment (by mikeschroder):

 Looked at this with @markoheijnen and a bit with @joemcgill (who has other
 comments as well), but a few notes:

 Attached [attachment:31050.2.diff]. I mis-applied some of the logic at the
 beginning of `image_downsize()`, which is fixed in the latest patch.

 However, now that it's working "properly," the black thumbnail issue is
 back, because it looks like the "full" size rendered JPGs are properly
 saved, whereas the thumbnails are not being generated correctly with all
 PDFs.  I'll dig into this to see whether it can be solved without
 intentionally making use of these.

 It's great that it highlights the issue, and we'll have to decide how to
 proceed.

 After chatting with @markoheijnen, I'm okay with proceeding without a
 filter for now, with the PDF detection parts within WP_Image_Editor, so
 removed the TODOs related to that, and documented the WP_Image_Editor
 changes a bit more.

 Also, changed the logic in `edit_form_image_editor()` so that
 `wp_edit_form_attachment_display` doesn't result in double output.

 Still to do: Double-check that `Imagick::readImage()` is available all the
 way back in versions of Imagick.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31050#comment:80>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform