[wp-trac] [WordPress Trac] #36202: Menus screen: fix persistence of toggles for displayed nav menu item properties

[WordPress Trac]

#36202: Menus screen: fix persistence of toggles for displayed nav menu item
properties
--------------------------+-----------------------------
 Reporter:  afercia       |       Owner:  ryankienstra
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  Menus         |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, javascript
--------------------------+-----------------------------

Comment (by ryankienstra):

 '''Commits To Address Form Submission Issue'''

 Hi @westonruter,
 You [https://core.trac.wordpress.org/ticket/36202#trac-
 change-4-1475464559859735 commented above] that on edit.php page, it's
 possible to refresh the page by clicking "Apply," before the ajax requests
 are sent. This [https://github.com/xwp/wordpress-
 develop/pull/159/commits/caa46b188429593149533fb7220efae54c5e2889 commit]
 to this ticket's [https://github.com/xwp/wordpress-
 develop/pull/159/commits GitHub pull request] passes
 [https://github.com/xwp/wordpress-
 develop/pull/159/commits/caa46b188429593149533fb7220efae54c5e2889#diff-
 731d55f699338973eaf2147ca0e0a61eR47 true] as the `immediate` argument to
 `_.debounce`. So this submits the first ajax request, without a `2000 ms`
 delay. So this fixes an issue where you click one "Columns" checkbox, like
 "Author," and quickly click "Apply."

 But there's still an issue if you click on several screen options, and
 then click "Apply." This next [https://github.com/xwp/wordpress-
 develop/pull/159/commits/fc0aa235553e4c61b76aacf24f87b525c03da2cc commit]
 delays form submission until the current ajax request completes. But there
 could be 3 ajax requests queued with [https://github.com/xwp/wordpress-
 develop/pull/159/files#diff-731d55f699338973eaf2147ca0e0a61eR35
 _.debounce]. This handler isn't very useful for clicking multiple screen
 options, and clicking "Apply."

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36202#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform