[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

WordPress Trac noreply at wordpress.org
Fri Oct 14 16:48:09 UTC 2016


#38172: Enable Video Headers in Custom Headers
----------------------------+--------------------
 Reporter:  davidakennedy   |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.7
Component:  Themes          |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------

Comment (by obenland):

 Replying to [comment:27 celloexpressions]:
 > I don't think this should be on by default in header images (due to
 likely-odd aspect ratio problems for many themes)

 Based on your example implementation for Twenty Fourteen it looks like we
 can't get around changes in `style.css`? I think it would be worth
 exploring if inlining `height: auto;` would make it work for themes with
 flexible height.

 > I don't think videos make sense for Ten, Eleven, Twelve, Thirteen, or
 Fifteen;

 Because they have elements preceding the header? I don't think that's an
 issue, if a default theme has a flexible height header, it should offer
 support for video headers.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list