[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
----------------------------+--------------------
 Reporter:  davidakennedy   |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.7
Component:  Themes          |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------

Comment (by celloexpressions):

 +1 for avoiding things that need to be separately maintained. Custom
 headers are a nightmare in terms of the customizer as well. That being
 said, the current implementation is probably simple enough that it'll be
 okay. If we add any additional fallbacks or want a way to let themes
 uniformly style the controls, we should switch to the existing
 functionality, which can be abstracted from `wp_video_shortcode()` to a
 generic video function used in both places.

 For selective refresh, I think the best approach for adding it to header
 images is to add partials where they can be added in core, and then rely
 on themes switching `transport` to `postMessage` on the header image
 setting. That way they'll always get edit icons when not using it as a
 background image, and themes can add the better selective refreshing with
 one line of code.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform