[wp-trac] [WordPress Trac] #37661: A New Experience for Discovering, Installing, and Previewing Themes in the Customizer
WordPress Trac
noreply at wordpress.org
Fri Oct 14 07:58:05 UTC 2016
#37661: A New Experience for Discovering, Installing, and Previewing Themes in the
Customizer
-------------------------------------+-------------------------------------
Reporter: celloexpressions | Owner: westonruter
Type: feature request | Status: reviewing
Priority: high | Milestone: 4.7
Component: Customize | Version: 4.2
Severity: normal | Resolution:
Keywords: has-patch has- | Focuses: ui, accessibility,
screenshots needs-testing has- | javascript
user-testing ux-feedback |
-------------------------------------+-------------------------------------
Comment (by afercia):
Excellent job with 'aria-label' and `wp.a11y.speak()`.
> The filters have aria-expanded, is that not working or the best approach
there?
Installed, Search, Featured, Popular, and Latest shouldn't use `aria-
expanded`: they don't expand/collapse anything, this should be remoed but
they still need an indication about which one is the selected view.
Feature Filter (+ nested accordions) and Favorites: the active state is
indicated by `aria-expanded`: they collapse when other views get selected
so it's OK to use just `aria-expanded` here
Using Firefox and Safari: when Feature Filter or Favorites are expanded
and you click on them, they don't close as expected, instead they
"bounce". Works on Chrome.
I'm not sure I understand this:
> In lieu of aria-labels within the details modal, announce what theme is
being displayed there, as all buttons within that view are contextual to
that theme.
About the Safari bug:
> I cannot reprocude the issue with the filters disappearing when
focussing a theme control.
Can consistently reproduce in Safari 10, looks like `transform:
translateX(100%);` gets triggered, not sure why
> See #34391 for the aria-owns thing.
OK, got it now. Thanks!
IMHO the search placeholder shouldn't be bold, it's inherited from the
container and seems an easy thing to fix
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37661#comment:100>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list