[wp-trac] [WordPress Trac] #37974: Add multi-panel feature to pages through add_theme_support
WordPress Trac
noreply at wordpress.org
Fri Oct 14 00:10:30 UTC 2016
#37974: Add multi-panel feature to pages through add_theme_support
-----------------------------------------+------------------
Reporter: karmatosed | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 4.7
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-ux-feedback needs-patch | Focuses: ui
-----------------------------------------+------------------
Comment (by pento):
[attachment:37974.13.diff] tweaks `WP_Query` to only include the the
section pages when `is_main_query()` is true.
It also no longer unsets the `page_id` parameter (instead, chooses to
ignore it when generating the SQL), so that it's still available to code
that expects it to be there. (Ie, code running on `pre_get_posts`) might
be checking something like this: `$query->get('page_id') ==
get_option('page_on_front')` (see #21790).
@bradyvercher: it seems like the `api.bind( 'ready', ...` code at the end
of `customize-post-collection.js` is very specific to this implementation
of the PostCollection. It probably should only run when it's in the
`static_front_page` section of the Customizer.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37974#comment:142>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list