[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

WordPress Trac noreply at wordpress.org
Thu Oct 13 15:48:27 UTC 2016


#38172: Enable Video Headers in Custom Headers
-----------------------------+--------------------
 Reporter:  davidakennedy    |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  4.7
Component:  Themes           |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+--------------------

Comment (by davidakennedy):

 @obenland Thanks for the continued feedback!

 > It would be helpful to keep everything in one patch rather than having
 to apply multiple patches that are potentially conflicting.

 The idea was my patch would be something @celloexpressions could pick up
 on and use. We talked about this in a recent features meeting for Twenty
 Seventeen. I thought it would be more valuable to post a in-progress patch
 in public since that means other people can provide feedback, even if it
 was not complete. It's better to share work early than not, even if it's
 not fully fleshed out yet.

 > The API still seems not to be as solid as it probably should be at this
 point in the cycle. It's not backwards compatible for themes that already
 support custom headers (which personally I think is a blocker for making
 it a core feature), and as far as I can tell the customizer control gets
 displayed regardless of the theme supporting videos or not?

 I realize that it still needs work, and the idea is for it to be backward
 compatible of course. I know we talked about some ideas in person recently
 for the theme API part of this feature, but could you lay out some more
 specific feedback? That would help immensely here. What would make it more
 "solid" in your mind, regardless of where we are in the cycle?

 > Having videos taking precedent over images is something we probably
 should explain in the customizer control as well. And inform them how they
 can use that as a fallback mechanism.

 Agreed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list