[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

WordPress Trac noreply at wordpress.org
Wed Oct 12 16:35:11 UTC 2016


#38172: Enable Video Headers in Custom Headers
-----------------------------+--------------------
 Reporter:  davidakennedy    |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  4.7
Component:  Themes           |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+--------------------

Comment (by davidakennedy):

 attachment:38172.2.patch revises the theme API part of the original patch:

 * Adds `video` param in custom header that defaults to false. To enable
 suppoet, themes would set it to true. It can be used to change the UI in
 the Customizer, based on that support too.
 * Uses custom header `height` and `width` instead of creating separate
 ones for videos.
 * Adds a `the_custom_header()` function which spits out markup for the
 custom header, giving the video tag precedence.
 * Uses header image as a `poster` attribute for `<video>` tag as a
 fallback when header image is available.

 Thanks to @joshcummingsdesign for working along with me to create a better
 patch. @celloexpressions Does this give you enough to work off of for the
 Customizer part?

 Things to think about still:

 * Should other fallbacks exist, like the MediaElement.js one that @pento
 suggested? I think so.
 * Should the `<video>` tag include anything else for browsers that don't
 support it. Or should that be left up to themers?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list