[wp-trac] [WordPress Trac] #37836: Cannot disable 'Add existing user'

[WordPress Trac]

#37836: Cannot disable 'Add existing user'
------------------------------+--------------------------------------------
 Reporter:  bseddon           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Users             |     Version:  3.1
 Severity:  normal            |  Resolution:
 Keywords:  needs-testing     |     Focuses:  ui, administration, multisite
  has-patch                   |
------------------------------+--------------------------------------------

Comment (by Mista-Flo):

 Here's a second patch. Thanks to @fperdaan for the review.

 Since the conditional test of $do_both is already made line 13 with the
 is_multisite, and user cap test, it does not necessary to test again with
 $both var, we only need to test if it's multisite.

 By the way the code of this file is really hard to read, a refactoring
 would be a nice thing to do to avoid DRY code.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37836#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform